-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Healthbot - Update Python.md based on az cli extension doc & Create Java.md file. #12263
Conversation
Hi, @guy-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
@lirenhe Ready for review. |
@ChenTanyi Does the readme.java.md look good to you ? |
@guy-microsoft Hi, Considering healthbot is a new service. I think it's better to add the python track2 configuration as well. You can change the readme.python.md following the sample here https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/documentation/samplefiles/readme.python.md |
Thanks @qiaozha, added. |
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java readme is OK
@guy-microsoft You might want to add title like this. According to autorest generic-extensions, the setting of x-ms-code-generation-settings is already deprecated. |
According to @00Kai0, only track2 is needed for new services python SDK, so I'm reverting the changes for python.md file. Only changes to java.md remain, which were approved. |
@guy-microsoft As @xccc-msft said, you might need to add title in |
@ChenTanyi When you say "title in java.md", what do you mean? |
@ChenTanyi Ok, but I'm still not sure what I should add to the readme.md file? Something like that? |
@guy-microsoft yes, you need to add a |
@ChenTanyi Thanks for clarifying, I added the Java section. Please let me know it's fine. |
@guy-microsoft You still didn't add |
@lirenhe, this PR is ready for approval and merge. Thanks. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.